Skip to content

test(browser-integration): Skip "browsertracing/backgroundtab-pageload" test for firefox #7475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2023
Merged

test(browser-integration): Skip "browsertracing/backgroundtab-pageload" test for firefox #7475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05c0613
test(browser-integration): Skip "browsertracing/backgroundtab-pageloa…
billyvg Mar 15, 2023
593f3e1
lint
billyvg Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions ...es/browser-integration-tests/suites/tracing/browsertracing/backgroundtab-pageload/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,24 @@ import type { Event } from '@sentry/types';
import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest } from '../../../../utils/helpers';

sentryTest('should finish pageload transaction when the page goes background', async ({ getLocalTestPath, page }) => {
const url = await getLocalTestPath({ testDir: __dirname });
sentryTest(
'should finish pageload transaction when the page goes background',
async ({ browserName, getLocalTestPath, page }) => {
// TODO: This is flakey on firefox... trace.status is sometimes undefined
Copy link
Member

@Lms24 Lms24 Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't even need the TODO here. IMO it's unlikely that we'll fix this any time soon.

if (['firefox'].includes(browserName)) {
sentryTest.skip();
}
const url = await getLocalTestPath({ testDir: __dirname });

await page.goto(url);
await page.click('#go-background');
await page.goto(url);
await page.click('#go-background');

const pageloadTransaction = await getFirstSentryEnvelopeRequest<Event>(page);
const pageloadTransaction = await getFirstSentryEnvelopeRequest<Event>(page);

expect(pageloadTransaction.contexts?.trace?.op).toBe('pageload');
expect(pageloadTransaction.contexts?.trace?.status).toBe('cancelled');
expect(pageloadTransaction.contexts?.trace?.tags).toMatchObject({
visibilitychange: 'document.hidden',
});
});
expect(pageloadTransaction.contexts?.trace?.op).toBe('pageload');
expect(pageloadTransaction.contexts?.trace?.status).toBe('cancelled');
expect(pageloadTransaction.contexts?.trace?.tags).toMatchObject({
visibilitychange: 'document.hidden',
});
},
);