Skip to content

chore(vscode): Add eslint working directories #7428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

chore(vscode): Add eslint working directories #7428

merged 1 commit into from
Mar 13, 2023

Conversation

@AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 13, 2023

https://twitter.com/brunoksato/status/1541026637705355264?lang=en

Turned this on so that we no longer get this error:

image

@AbhiPrasad AbhiPrasad requested review from a team, Lms24 and mydea and removed request for a team March 13, 2023 09:40
mydea
mydea approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, great to get rid of this!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.24 KB (+0.11% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 62.95 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.87 KB (+0.1% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55.87 KB (+0.12% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.62 KB (+0.12% 🔺)
@sentry/browser - Webpack (minified) 67.39 KB (+0.1% 🔺)
@sentry/react - Webpack (gzipped + minified) 20.65 KB (+0.12% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.54 KB (+0.18% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.51 KB (+0.22% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.76 KB (+0.21% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.17 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 37.19 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.18 KB (+0.09% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 54.35 KB (+0.04% 🔺)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 13, 2023 09:46
@AbhiPrasad AbhiPrasad merged commit 9c2971b into develop Mar 13, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-vscode-eslint-test branch March 13, 2023 09:49
mydea added a commit that referenced this pull request Mar 24, 2023
@mydea
build: Remove test/tsconfig.json files
50efb89 
It seems we do not need them anymore for VSCode, I guess since #7428.
@mydea mydea mentioned this pull request Mar 24, 2023
Merged
mydea added a commit that referenced this pull request Mar 24, 2023
@mydea
build: Remove test/tsconfig.json files
f253c3c 
It seems we do not need them anymore for VSCode, I guess since #7428.
mydea added a commit that referenced this pull request Mar 24, 2023
@mydea
build: Remove test/tsconfig.json files
b0f20c9 
It seems we do not need them anymore for VSCode, I guess since #7428.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AbhiPrasad @mydea @Lms24