Skip to content

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Mar 8, 2023

We need to expose a similar option to tracesSampler but for profiling purposes. I kept the signature identical to tracing (maybe I should just reuse the same type?) as profiling just wraps that same startTransaction call.

We need to wait before merging to add the relevant changes to the profiling repository, I would just like to get some feedback on the type before proceeding

@JonasBa JonasBa requested review from AbhiPrasad and lforst March 8, 2023 16:08
@JonasBa JonasBa force-pushed the feat/node/profilessampler branch from 3bb61aa to 3d1af3f Compare March 8, 2023 16:09
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.15 KB (+0.17% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 62.63 KB (+0.18% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.79 KB (+0.17% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55.61 KB (+0.21% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.53 KB (+0.18% 🔺)
@sentry/browser - Webpack (minified) 67.1 KB (+0.17% 🔺)
@sentry/react - Webpack (gzipped + minified) 20.56 KB (+0.17% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.3 KB (+0.07% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.29 KB (+0.12% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.55 KB (+0.14% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.15 KB (+0.08% 🔺)
@sentry/replay - Webpack (gzipped + minified) 37.16 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.94 KB (+0.06% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 54.26 KB (+0.06% 🔺)

@lforst lforst changed the title feat(types): add profilesSampler option to node client type feat(types): Add profilesSampler option to node client type Mar 9, 2023
@JonasBa JonasBa merged commit 63ef40e into develop Mar 10, 2023
@JonasBa JonasBa deleted the feat/node/profilessampler branch March 10, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants