ref(node): store split file in cache for contextlines #7383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
force-pushed
the
ref/perf/contextlines-file
branch
from
8271990 to
18eb932
Compare
AbhiPrasad
approved these changes
Mar 8, 2023
AbhiPrasad
changed the title
Contributor
size-limit report 📦
|
timfish
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were storing the file as a raw string in cache and performing the .split(\n) inside our for(frame of frames) loop... This means that for stack traces with functions belonging to the same file, the file was split multiple times - this is inefficient and we can do better by storing the file as it's split version in cache and avoiding the unnecessary duplicate split operations.