Skip to content

test(replay): Make tests less flaky #7368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2023
Merged

test(replay): Make tests less flaky #7368

merged 3 commits into from
Mar 7, 2023

Conversation

@mydea
Copy link
Member

@mydea mydea commented Mar 7, 2023

I've seen a few places where snapshot order got changed, which was a bit hard to understand.

This PR updates the snapshots to:

  1. Ensure entries are always ordered by timestamp
  2. Simply use the whole snapshot (instead of just data) for better clarity. We just replace timestamp with [timestamp].

@mydea mydea requested review from Lms24 and billyvg March 7, 2023 13:39
@mydea mydea self-assigned this Mar 7, 2023
Lms24
Lms24 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mydea
Copy link
Member Author

mydea commented Mar 7, 2023

So, since this is still flaky, I will filter out the ones with source: 1, which means it's a mouse movement. As we don't really test those, IMHO it's fine to filter them out here.

billyvg
billyvg approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, that's odd that they weren't ordered

packages/integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy-firefox.json
"left": 0,
"top": 0
}
"timestamp": [timestamp]
Copy link
Member

@billyvg billyvg Mar 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

twitch

Copy link
Member Author

@mydea mydea Mar 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 we can also leave it 0?

@mydea mydea merged commit f8b56b0 into develop Mar 7, 2023
@mydea mydea deleted the fn/unflake-tests branch March 7, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billyvg billyvg billyvg approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels

Type: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mydea @billyvg @Lms24