ref(e2e): Make Next.js app dir tests more thorough #7336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 2, 2023 15:05
added 3 commits
March 6, 2023 12:21
AbhiPrasad
approved these changes
Mar 6, 2023
| }, | ||
| { | ||
| "dependencyOverrides": { | ||
| "next": "canary" |
Member
There was a problem hiding this comment.
Do we need to have latest if we already have canary?
Contributor
Author
There was a problem hiding this comment.
Yes. They could theoretically diverge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-work to #7228
I noticed that while adding features to our Next.js app dir instrumentation that it was very easy for us to break Next.js builds that wouldn't have been caught by our test suite.
This PR makes the E2E test Next.js app dir application more fleshed out so that we are more likely to catch build errors.