Skip to content

test(core): Skip flaky offline transport test #7312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2023
Merged

test(core): Skip flaky offline transport test #7312

merged 2 commits into from
Mar 1, 2023

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 1, 2023

This PR

  1. reverts test(browser): Temporarily skip offline transport tests #7305 as it seems these tests were in fact not flaky 🙈
  2. skips the actually flaky offline test from core, mentioned in [Flaky CI]: Node (16) Unit Tests @sentry/core offline.test.ts #7079 until we properly fix the flake

@Lms24 Lms24 requested review from lforst and mydea March 1, 2023 14:05
@Lms24 Lms24 self-assigned this Mar 1, 2023
@Lms24 Lms24 added Package: core Issues related to the Sentry Core SDK Type: Tests labels Mar 1, 2023
@Lms24 Lms24 merged commit ca1352d into develop Mar 1, 2023
@Lms24 Lms24 deleted the lms/skip-core-offline-test branch March 1, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@Lms24 Lms24

Labels

Package: core Issues related to the Sentry Core SDK Type: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24 @mydea