Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 22, 2023

While working on #7082 we figured it'd be worthwhile to check that we handle unicode characters correctly. Especially when compressing payload we should check that nothing goes wrong.

Note: This test obviously only checks that the payloads leave the SDK correctly. It cannot say anything about the replayer rendering them correctly in the Sentry UI.

ref #7044

@mydea
Copy link
Member

mydea commented Feb 22, 2023

This is nice, might be worthwhile to also include this in the E2E test: #7249 - I'll leave a note there!

@Lms24 Lms24 marked this pull request as ready for review February 22, 2023 13:49
@Lms24 Lms24 requested review from billyvg and mydea February 22, 2023 13:51
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.07 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 62.3 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.69 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55.31 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.41 KB (0%)
@sentry/browser - Webpack (minified) 66.76 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.44 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.86 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.94 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.2 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.61 KB (+0.11% 🔺)
@sentry/replay - Webpack (gzipped + minified) 36.82 KB (+0.12% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.24 KB (+0.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 53.84 KB (+0.08% 🔺)

@Lms24 Lms24 added Type: Tests Package: replay Issues related to the Sentry Replay SDK labels Feb 22, 2023
@Lms24 Lms24 merged commit c5c223c into develop Feb 22, 2023
@Lms24 Lms24 deleted the lms/replay-pw-unicode branch February 22, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Package: replay Issues related to the Sentry Replay SDK Type: Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants