test(replay): Normalize time offset in DOM snapshots #7219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Feb 17, 2023
| const rawString = JSON.stringify(obj, null, 2); | ||
| const normalizedString = rawString.replace(/"file:\/\/.+(\/.*\.html)"/g, '"$1"'); | ||
| const normalizedString = rawString | ||
| .replace(/"file:\/\/.+(\/.*\.html)"/, '"$1"') |
Member
There was a problem hiding this comment.
m: should both of these regexes have a /gm (or at least /g, not 100% sure tbh) suffix? I
Member
Author
There was a problem hiding this comment.
Done, plus another regex fix (I didn't take negative offsets into account)
AbhiPrasad
reviewed
Feb 17, 2023
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Do we need to also update snapshots?
| const normalizedString = rawString.replace(/"file:\/\/.+(\/.*\.html)"/g, '"$1"'); | ||
| const normalizedString = rawString | ||
| .replace(/"file:\/\/.+(\/.*\.html)"/, '"$1"') | ||
| .replace(/"timeOffset":\s*\d+/, '"timeOffset": 0'); |
Member
There was a problem hiding this comment.
m: I would prefer it if we made the redaction explicit here.
Suggested change
| .replace(/"timeOffset":\s*\d+/, '"timeOffset": 0'); | |
| .replace(/"timeOffset":\s*\d+/, '"timeOffset": [timeOffset]'); |
Member
Author
There was a problem hiding this comment.
With the redaction we now need to update snapshots :D
AbhiPrasad
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed that the last integration test I added in #7212 is flaky because of time offsets which can change in some CI runs. This PR normalizes the time offset to
[timeOffset]in DOM snapshots to make sure this doesn't happen.