Skip to content

ci: Ensure we can actually run size-limit for release branches #7214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2023
Merged

ci: Ensure we can actually run size-limit for release branches #7214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,14 @@ jobs:
path: ${{ env.CACHED_BUILD_PATHS }}
key: ${{ env.BUILD_CACHE_KEY }}
- name: Check bundle sizes
uses: getsentry/size-limit-action@main-skip-step
uses: getsentry/size-limit-action@runForBranch
Copy link
Member

@Lms24 Lms24 Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to change this once the PR is merged and the branch is deleted, right?

Copy link
Member Author

@mydea mydea Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jup, although the previous state was also still using the branch 😅 but yes, def should do a new "release" then. But I'll wait on billy to review there first.

with:
github_token: ${{ secrets.GITHUB_TOKEN }}
skip_step: build
main_branch: develop
# When on release branch, we want to always run
# Else, we fall back to the default handling of the action
run_for_branch: ${{ (needs.job_get_metadata.outputs.is_release == 'true' && 'true') || '' }}

job_lint:
name: Lint
Expand Down