feat(otel): Convert exception otel events to sentry errors #7165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
lforst and
mydea
and removed request for
a team
lforst
approved these changes
Feb 13, 2023
Contributor
lforst
left a comment
lforst
left a comment
There was a problem hiding this comment.
lgtm - is there a chance we double report errors now?
Member
Author
Good question - let me take a look to see how robust auto-instrumentation is. Generally though it's no - since users have to manually call |
Member
Author
|
Took a look - the answer is no for now, but we can re-evaluate if/when that changes. |
Contributor
size-limit report 📦
|
AbhiPrasad
force-pushed
the
abhi-add-otel-exception-events
branch
2 times, most recently
from
2518492 to
a1fdc86
Compare
Member
Author
|
woops accidentally rebased off of master - needed some git-fu to get that back |
always set message oof prettier add otel context
AbhiPrasad
force-pushed
the
abhi-add-otel-exception-events
branch
from
a1fdc86 to
44b37e3
Compare
ramchaik
pushed a commit
to ramchaik/sentry-javascript
that referenced
this pull request
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref getsentry/team-webplatform-meta#31
In OpenTelemetry, spans can have exception events.
Let's create Sentry errors from these exception events and send them to Sentry! We can link them to the parent transaction via trace context.