Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 13, 2023

Waiting on 👍 from @billyvg

Lms24 and others added 11 commits February 10, 2023 10:19
This fixes an issue found in #7020 where `unblock` was not working for SVGs. This was due to our default media selectors including svg child elements. rrweb will handle blocking these as needed when the parent SVG is blocked.
[Gitflow] Merge master into develop
Upgrades rrweb library which will includes:

- feat: Add `maskAllText` option
- feat: With maskAllText, mask the attributes: placeholder, title, `aria-label`
- feat: fix masking on `textarea`
test(replay): Test against full and errors+replay CDN bundles
@Lms24 Lms24 requested a review from billyvg February 13, 2023 12:04
@Lms24
Copy link
Member Author

Lms24 commented Feb 13, 2023

We're gonna bump rrweb again - draft until ready

@Lms24 Lms24 marked this pull request as draft February 13, 2023 12:07
CHANGELOG.md Outdated

## 7.37.2

This release includes [changes and fixes](https://github.com/getsentry/rrweb/releases/tag/1.102.0) around text masking in Replay's `rrweb` dependency.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be helpful to just embed rrweb changelog in here?

Suggested change
This release includes [changes and fixes](https://github.com/getsentry/rrweb/releases/tag/1.102.0) around text masking in Replay's `rrweb` dependency.
This release includes [changes and fixes](https://github.com/getsentry/rrweb/releases/tag/1.102.0) around text masking in Replay's `rrweb` dependency:
- feat: Add `maskAllText` option
- feat: With maskAllText, mask the attributes: placeholder, title, `aria-label`
- feat: fix masking on `textarea`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done: f811483

@Lms24 Lms24 force-pushed the prepare-release/7.37.2 branch from 9059209 to f811483 Compare February 13, 2023 13:40
@Lms24 Lms24 marked this pull request as ready for review February 13, 2023 13:41
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.07 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 62.2 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.7 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 55.34 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.43 KB (0%)
@sentry/browser - Webpack (minified) 66.78 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.46 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.85 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.99 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.24 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.49 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 36.89 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.17 KB (0%)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 53.73 KB (0%)

@Lms24 Lms24 force-pushed the prepare-release/7.37.2 branch from f811483 to 53046d8 Compare February 13, 2023 14:15
@Lms24 Lms24 merged commit 43965f2 into master Feb 13, 2023
@Lms24 Lms24 deleted the prepare-release/7.37.2 branch February 13, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants