Skip to content

feat(replay): Improve rrweb error ignoring #7087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2023
Merged

feat(replay): Improve rrweb error ignoring #7087

merged 1 commit into from
Feb 8, 2023

Conversation

@mydea
Copy link
Member

@mydea mydea commented Feb 8, 2023

Based on getsentry/rrweb#41, we can now ignore rrweb errors even when the code is minified.

@mydea
feat(replay): Improve rrweb error ignoring
990cd1e 
Based on getsentry/rrweb#41, we can now ignore rrweb errors even when the code is minified.
@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Feb 8, 2023
@mydea mydea requested review from Lms24 and billyvg February 8, 2023 09:30
@mydea mydea self-assigned this Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.91 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.72 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.59 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 55.02 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.32 KB (0%)
@sentry/browser - Webpack (minified) 66.48 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.35 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.64 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.12 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.88 KB (+0.06% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.79 KB (+0.09% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.5 KB (+0.05% 🔺)

@mydea mydea merged commit 2c4366c into develop Feb 8, 2023
@mydea mydea deleted the fn/better-ignore-rrweb-errors branch February 8, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@billyvg billyvg Awaiting requested review from billyvg

Assignees

@mydea mydea

Labels

Package: replay Issues related to the Sentry Replay SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea @Lms24