Skip to content

Conversation

@AbhiPrasad
Copy link
Member

Resolves #7066

Generate CDN bundle (es6 only) for Replay + errors. This gives us all the possible permutations between errors, replays and performance to dynamically load CDN bundle as appropriate for the new loader work.

@AbhiPrasad AbhiPrasad requested review from Lms24 and mydea February 6, 2023 14:13
@AbhiPrasad AbhiPrasad self-assigned this Feb 6, 2023
@AbhiPrasad
Copy link
Member Author

Hmm, I wonder why the integration tests fail 🤔

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think the failing PW tests are more related to the Ubuntu registry problem than the PR...

m: Can we add a size-check entry for the bundle? (feel free to do that in a follow-up PR)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.06 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 62.19 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.69 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 55.33 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.42 KB (0%)
@sentry/browser - Webpack (minified) 66.77 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.45 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.74 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.97 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.23 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.85 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.76 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.57 KB (-0.01% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.09 KB (added)

@AbhiPrasad AbhiPrasad merged commit 8ef71d1 into develop Feb 8, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-replay-only-errors branch February 8, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create CDN Bundle for just Error + Replay

3 participants