fix(replay): Only call scope.getLastBreadcrumb if available
#6969
Conversation
| * An event handler to handle scope changes. | ||
| */ | ||
| export function handleScope(scope: Scope): Breadcrumb | null { | ||
| if (typeof scope.getLastBreadcrumb !== 'function') { |
There was a problem hiding this comment.
LGTM. 👍🏼
I wish i would have created this PR before 🤦🏼 🥼
There was a problem hiding this comment.
According to this methods signature, scope is always defined; so no need to guard against it being undefined ;)
Furthermore, this is where we call the function that ends up calling handleScope. As you can see, it is guarded by the scope being defined there:
There was a problem hiding this comment.
awesome sauce... 🆒 . The guarded scope looks good ⚡
There was a problem hiding this comment.
l: I would just do if (scope.getLastBreadcrumb), saves some bytes and should be good enough here!
size-limit report 📦
|
mydea
left a comment
mydea
left a comment
There was a problem hiding this comment.
👍 LGTM! For reference, let's do this fix, with the conscious decision that if such things keep popping up, we'll not commit to work around all of them. 🚀
Scope.getLastBreadcrumbwas introduced quite recently for replay and it generally works fine. Just in the few edge cases, where the base SDK version can't be changed or multiple hubs cause conflicts, Replay will crash when the method is not available on the passed scope. This PR letshandleScopeearly-returnnullin case thegetLastBreadcrumbmethod does not exist. This will lead to missing breadcrumbs in the replay but at least it will avoid a crash.closes #6542