Skip to content

Conversation

@onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Jan 19, 2023

Resolves: #6868

Increasing flush interval to 1000ms to 2000ms, with overall timeout from 2000ms to 4000ms.

Looks like the test flakes because of early-flushing (before 'slow' endpoint finishes), so also decreased the slowness of the 'slow' endpoint.

This branch consistently succeeded on local, will test on CI here.


Update: None of the 11 CI runs here have failed session tests.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.83 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.48 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.5 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 54.79 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.22 KB (0%)
@sentry/browser - Webpack (minified) 66.19 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.25 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.48 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.75 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.03 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.26 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.04 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.52 KB (-0.01% 🔽)

@onurtemizkan onurtemizkan force-pushed the onur/node-session-tests-flush-interval branch from 2864bcc to c13221a Compare January 19, 2023 16:58
@onurtemizkan onurtemizkan marked this pull request as ready for review January 20, 2023 16:35
@onurtemizkan onurtemizkan force-pushed the onur/node-session-tests-flush-interval branch from c13221a to 6d3cc84 Compare January 20, 2023 16:42
@AbhiPrasad AbhiPrasad merged commit 7c2df8e into master Jan 23, 2023
@AbhiPrasad AbhiPrasad deleted the onur/node-session-tests-flush-interval branch January 23, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Flaky CI]: exited-session-aggregate in Node 12 integration tests

3 participants