Skip to content

chore: update metrics PR comment diff/percentage base #6849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2023
Merged

chore: update metrics PR comment diff/percentage base #6849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/replay/metrics/src/results/pr-comment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ export class PrCommentBuilder {
<td align="right"><strong>${values.diff(0, 1)}</strong></td>
<td align="right"><strong>${values.percent(0, 1)}</strong></td>
<td align="right">${values.value(2)}</td>
<td align="right"><strong>${values.diff(1, 2)}</strong></td>
<td align="right"><strong>${values.percent(1, 2)}</strong></td>
<td align="right"><strong>${values.diff(0, 2)}</strong></td>
<td align="right"><strong>${values.percent(0, 2)}</strong></td>
`;
}

Expand Down Expand Up @@ -141,7 +141,7 @@ export class PrCommentBuilder {
this._buffer += `<tr><th>${resultFile.hash}</th>`;
for (const item of analysis.items) {
// TODO maybe find a better way of showing this. After the change to multiple scenarios, this shows diff between "With Sentry" and "With Sentry + Replay"
this._buffer += `<td align="right">${item.values.diff(1, 2)}</td>`;
this._buffer += `<td align="right">${item.values.diff(0, 2)}</td>`;
}
this._buffer += '</tr>';
}
Expand Down
4 changes: 2 additions & 2 deletions packages/replay/metrics/src/util/console.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ export function printAnalysis(analysis: Analysis): void {
table[AnalyzerItemMetric[item.metric]] = {
value: item.values.value(0),
withSentry: item.values.diff(0, 1),
withReplay: item.values.diff(1, 2),
withReplay: item.values.diff(0, 2),
...((item.others == undefined) ? {} : {
previous: item.others.value(0),
previousWithSentry: item.others.diff(0, 1),
previousWithReplay: item.others.diff(1, 2)
previousWithReplay: item.others.diff(0, 2)
})
};
}
Expand Down