Skip to content

test(nextjs): Streamline integration tests #6839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 18, 2023
Merged

test(nextjs): Streamline integration tests #6839

merged 5 commits into from
Jan 18, 2023

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Jan 18, 2023 •
edited
Loading

This PR

  • Makes integration tests runnable on a debian dev container
  • Fails CI on flakes (we hate flakes and want to get rid of them immediately)
  • Removes unused yarn scripts
  • Removes logic that double-built the Next.js project when running test:integration
  • Fixes the flaky tracingFetch test

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.82 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.47 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.5 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.22 KB (0%)
@sentry/browser - Webpack (minified) 66.17 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.24 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.52 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.74 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.03 KB (+0.05% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.12 KB (-0.82% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.45 KB (-1% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.37 KB (-0.58% 🔽)

@lforst lforst force-pushed the lforst-nextjs-integration-chromium branch from 7d82e11 to 8d0ef2f Compare January 18, 2023 11:34
@lforst lforst changed the title test(nextjs): Only run integration tests on chromium test(nextjs): Streamline integration tests Jan 18, 2023
@lforst lforst marked this pull request as ready for review January 18, 2023 13:36
@lforst lforst requested review from AbhiPrasad and Lms24 January 18, 2023 13:36
AbhiPrasad
AbhiPrasad approved these changes Jan 18, 2023
View reviewed changes
packages/nextjs/playwright.config.ts

const config: PlaywrightTestConfig = {
retries: 2,
retries: 0, // We do not accept flakes.
Copy link
Member

@AbhiPrasad AbhiPrasad Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

famous last words

Copy link
Contributor Author

@lforst lforst Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao

@lforst lforst merged commit a555cd8 into master Jan 18, 2023
@lforst lforst deleted the lforst-nextjs-integration-chromium branch January 18, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lforst @AbhiPrasad