ref(replay): Extract sendReplay functionality into functions
#6751
Conversation
|
|
||
| await advanceTimers(30000); | ||
| expect(mockSendReplayRequest).toHaveBeenCalledTimes(4); | ||
| expect(spySendReplay).toHaveBeenCalledTimes(4); |
There was a problem hiding this comment.
Note: We cannot spy on recursive calls of modules, it seems, so this is never incremented. IMHO this is well enough tested by ensure that sendReplayRequest is called X times, we don't really care that much about sendReplay does.
size-limit report 📦
|
mydea
force-pushed
the
fn/send-replay-extract
branch
from
bee9cf7 to
f84854d
Compare
mydea
force-pushed
the
fn/send-replay-extract
branch
from
f84854d to
caec2f7
Compare
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Nice, looks like a great change to me.
| recordingHeader?: RecordingHeader; | ||
| recordingPayloadHeader?: RecordingPayloadHeader; | ||
| events?: ReplayRecordingData; | ||
| recordingData?: ReplayRecordingData; |
There was a problem hiding this comment.
great change, "event" is overloaded enough already 😅
| await new Promise(process.nextTick); | ||
| expect(replay).toHaveLastSentReplay({ | ||
| events: JSON.stringify([ | ||
| recordingData: JSON.stringify([ |
There was a problem hiding this comment.
Just to double check: This renaming doesn't change anything for the actual envelope content that is sent to Sentry, right? Just don't wanna risk some problem with Relay not finding the field it expects in the envelope
There was a problem hiding this comment.
no, this basically reads the SendReplayData passed around!
This extracts this out into a more functional style.
In addition, it also changes the
timestampwe put on the replay to always reflect the time we've added it, no matter if it was retried.This also renames a few things for clarity (e.g.
eventsthat was often passed around is actuallyrecordingData, so we may as well reflect that in order to be clear about recordingData vs. events).Note: This depends on #6733, where I'll need to merge the changes once that is merged.