Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Jan 12, 2023

This updates rrweb & rrweb-snapshot to the latest patched version from here: https://github.com/getsentry/rrweb/tree/sentry-v1

Steps:

  • Run yarn && yarn build:all in rrweb
  • Copy dist, es, lib & types folders from rrweb/rrweb-snapshot into sentry-javascript
  • Run npx patch-package rrweb / npx patch-package rrweb-snapshot in sentry-javascript

You can see that it is rather hard to grasp and follow, but I think it is what we want here.

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Jan 12, 2023
@mydea mydea requested review from Lms24 and billyvg January 12, 2023 09:55
@mydea mydea self-assigned this Jan 12, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (0%)
@sentry/browser - Webpack (minified) 66.55 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.63 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.13 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.33 KB (0%)

Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this but we should consider releasing this as a package on npm going forward

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because I'm super paranoid about this stuff: Did you test this in a test app?

@mydea
Copy link
Member Author

mydea commented Jan 13, 2023

I tried it in a small test app of mine, and it appeared all fine to me. (But of course this does not test everything)

@mydea mydea mentioned this pull request Jan 13, 2023
@mydea mydea merged commit 57b3ccb into master Jan 16, 2023
@mydea mydea deleted the fn/rrweb-update branch January 16, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Package: replay Issues related to the Sentry Replay SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants