Skip to content

test(replay): Add basic replay integration tests #6735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2023
Merged

test(replay): Add basic replay integration tests #6735

merged 2 commits into from
Jan 12, 2023

Conversation

@mydea
Copy link
Member

@mydea mydea commented Jan 11, 2023

Adds two very basic integration tests for replay.

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Jan 11, 2023
@mydea mydea requested review from Lms24 and billyvg January 11, 2023 13:56
@mydea mydea self-assigned this Jan 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (0%)
@sentry/browser - Webpack (minified) 66.55 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.63 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.95 KB (-0.43% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.33 KB (-0.01% 🔽)

billyvg
billyvg approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Lms24
Lms24 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great!

@mydea mydea force-pushed the fn/replay-integration-tests branch from 07b64aa to 4e9f785 Compare January 12, 2023 10:35
@mydea
Copy link
Member Author

mydea commented Jan 12, 2023

Note: The tests do not work in bundle mode (I guess some work has to be done there to include the replay bundle). For now, I just skip them in these envs. In the future, when we have a full bundle incl. replay, we may want to re-enable this somehow.

@mydea mydea merged commit 2e281ad into master Jan 12, 2023
@mydea mydea deleted the fn/replay-integration-tests branch January 12, 2023 13:36
@Lms24 Lms24 mentioned this pull request Jan 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billyvg billyvg billyvg approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels

Package: replay Issues related to the Sentry Replay SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mydea @billyvg @Lms24