build: Improve nx caching strategy #6731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `build:tarball` is actually not cacheable 2. Make sure that we do not mark a package as needing to rebuild when tests change 3. Add missing dependencies for serverless build
mydea
commented
Jan 11, 2023
| "{workspaceRoot}/*.json", | ||
| "{workspaceRoot}/yarn.lock" | ||
| ], | ||
| "default": [ |
Member
Author
There was a problem hiding this comment.
note on this: This means that by default, a job is considered changed when one of these given files changes. meaning we do not consider a build to have to re-run when we change only a file in the tests, or a markdown file.
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build:tarballis actually not cacheableNote that we are still very defensive and will rebuild quite often. E.g. when you change a file in replay/src, it will not cache replay, browser, and anything that depends on browser. but IMHO it is better to be too defensive, so that's OK.
Reference: https://nx.dev/more-concepts/customizing-inputs