feat(nextjs): Add optional options argument to withSentryConfig as an alternative to the sentry property
#6721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
scefali
reviewed
Jan 10, 2023
scefali
reviewed
Jan 10, 2023
scefali
reviewed
Jan 10, 2023
scefali
reviewed
Jan 10, 2023
lforst
changed the title
lforst
reviewed
Jan 11, 2023
lforst
reviewed
Jan 11, 2023
lforst
reviewed
Jan 11, 2023
lforst
reviewed
Jan 11, 2023
lforst
changed the title
withSentryConfig as an alternative to the sentry property
lforst
approved these changes
Jan 12, 2023
Contributor
|
This is probably gonna go out with a release on Monday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a new optional argument for withSentryConfig that allows for easier merging of the next.config.js files in the Sentry Wizard. Now, the Wizard will call withSentryConfig with the 3rd argument which adds in the Sentry options we want to add to the config. This allows for easier merging of the config files, as 2 lines can be added to the existing next.config.js for it to work (getsentry/sentry-wizard#222)