test(nextjs): Migrate Next SDK's client side tests to Playwright. #6718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/next-new-integration-tests
branch
2 times, most recently
from
73e0c47 to
372d196
Compare
onurtemizkan
force-pushed
the
onur/next-new-integration-tests
branch
from
66b1c0c to
46a0403
Compare
5 tasks
onurtemizkan
force-pushed
the
onur/next-new-integration-tests
branch
from
9a070d2 to
fb72f5e
Compare
onurtemizkan
force-pushed
the
onur/next-new-integration-tests
branch
2 times, most recently
from
2840a77 to
d5ea798
Compare
onurtemizkan
force-pushed
the
onur/next-new-integration-tests
branch
from
d5ea798 to
9ea25b3
Compare
AbhiPrasad
approved these changes
Jan 18, 2023
lforst
reviewed
Jan 18, 2023
Contributor
lforst
left a comment
lforst
left a comment
There was a problem hiding this comment.
In general, these changes seem good to me! 👍
Just saw that @AbhiPrasad merged this but I think I identified some potential flakes we should get rid of.
Comment on lines
+9
to
+10
| page.click('button'), | ||
| getMultipleSentryEnvelopeRequests<Event>(page, 1, { envelopeType: 'event' }), |
Member
There was a problem hiding this comment.
We've done this before with no issues:
We can adjust this if it is causing flakes.
Comment on lines
+14
to
+19
| await page.waitForTimeout(250); | ||
|
|
||
| const [, events] = await Promise.all([ | ||
| page.click('a#alsoHealthy'), | ||
| getMultipleSentryEnvelopeRequests<Session>(page, 2, { envelopeType: 'session' }), | ||
| ]); |
Comment on lines
+37
to
+40
| const [, events_2] = await Promise.all([ | ||
| page.click('a#healthy'), | ||
| getMultipleSentryEnvelopeRequests<Session>(page, 2, { envelopeType: 'session' }), | ||
| ]); |
Comment on lines
+24
to
+25
| page.click('a#server-side-props-page'), | ||
| getMultipleSentryEnvelopeRequests<Transaction>(page, 1, { envelopeType: 'transaction' }), |
Comment on lines
+44
to
+45
| page.click('a#initial-props-page'), | ||
| getMultipleSentryEnvelopeRequests<Transaction>(page, 1, { envelopeType: 'transaction' }), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #6053
This PR migrates NextJS client-side integration tests from Puppeteer to Playwright, removing the dependency on the
puppeteerpackage.countEnvelopesfunction is implemented in our integration-test utilities which gets the number of total envelopes sent in a certain timescale in browser.Will be addressed in other PRs
node-integration-testsutilities.