fix(remix): Make remix SDK type exports isomorphic #6715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 10, 2023 15:05
Contributor
size-limit report 📦
|
Lms24
approved these changes
Jan 10, 2023
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
just checking, no action required: Do we not need to restructure things here like in NextJS?
Contributor
Author
Not required but we definitely should in the future! The reason I restructured things in the Next.js SDK was as preparation for app directory and edge runtime changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6705
This PR makes the Remix SDK typings isomorphic by creating a type-only entrypoint that exports everything from the client part of the SDK and everything from the server part of the SDK.