Skip to content

feat(core): Add addIntegration method to client #6651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2023
Merged

feat(core): Add addIntegration method to client #6651

merged 2 commits into from
Jan 5, 2023

Conversation

@mydea
Copy link
Member

@mydea mydea commented Jan 4, 2023 •
edited
Loading

This can be used to add an integration at runtime.

This is useful e.g. for replay, where we may want to lazy load this (as the payload is quite large).

@mydea mydea added Type: Feature Package: core Issues related to the Sentry Core SDK labels Jan 4, 2023
@mydea mydea requested review from Lms24 and lforst January 4, 2023 10:43
@mydea mydea self-assigned this Jan 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (+0.11% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.43 KB (+0.15% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.61 KB (+0.09% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.98 KB (+0.13% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (+0.11% 🔺)
@sentry/browser - Webpack (minified) 66.62 KB (+0.14% 🔺)
@sentry/react - Webpack (gzipped + minified) 20.41 KB (+0.1% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.65 KB (+0.05% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.81 KB (+0.11% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (+0.11% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.99 KB (-0.02% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.24 KB (+0.01% 🔺)

lforst
lforst approved these changes Jan 4, 2023
View reviewed changes
@mydea mydea force-pushed the fn/addIntegration branch from fa86704 to 3b74327 Compare January 4, 2023 12:42
Lms24
Lms24 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks like bundle size impact is negligible so I'd say let's go for it!

mydea added 2 commits January 5, 2023 09:25
@mydea
feat(core): Add addIntegration method to client
db525cf 
This can be used to add an integration at run time.
@mydea
ref: Add todo note
bd399b3
@mydea mydea force-pushed the fn/addIntegration branch from 3b74327 to bd399b3 Compare January 5, 2023 08:27
@mydea mydea merged commit 55d708f into master Jan 5, 2023
@mydea mydea deleted the fn/addIntegration branch January 5, 2023 09:01
@shouze shouze mentioned this pull request May 2, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

+2 more reviewers

@jason-hwang jason-hwang jason-hwang left review comments

@lforst lforst lforst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mydea mydea

Labels

Package: core Issues related to the Sentry Core SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mydea @jason-hwang @lforst @Lms24