fix(replay): Improve handling of maskAllText selector
#6637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of the replay
maskAllTextoption in two ways:maskAllText === truewe overwrite themaskTextSelector. However, since we setmaskAllText = trueby default, this means that if you configure replay like this:This will actually be overwritten by the maskAllText selector, because internally
maskAllTextis true.This PR changes this behavior so that we only overwrite it if either we explicitly state
maskAllText: true, or if we do not set it at all and nomaskTextSelectoris specified.So the new behavior is:
:not(), see: https://developer.mozilla.org/en-US/docs/Web/CSS/:not#browser_compatibilitySo I changed this to avoid using this selector type.
Closes #6618