Skip to content

fix(replay): Envelope send should be awaited in try/catch #6625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2023
Merged

fix(replay): Envelope send should be awaited in try/catch #6625

merged 1 commit into from
Jan 3, 2023

Conversation

@timfish
Copy link
Collaborator

@timfish timfish commented Dec 29, 2022

I was just checking all the places where the Transport send is called and noticed this.

If the promise is not awaited within the try, the catch will never be called.

@timfish timfish self-assigned this Dec 30, 2022
@mydea mydea self-requested a review January 3, 2023 08:35
mydea
mydea approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@mydea mydea merged commit a11659a into getsentry:master Jan 3, 2023
@timfish timfish deleted the fix/replay-await-catch branch January 5, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes

Assignees

@timfish timfish

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timfish @mydea