fix(tracing): Don't finish React Router 6 pageload transactions early
#6609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 22, 2022 14:19
Collaborator
|
@lforst -- Ran it through debugger, and seems to be working fine. (with and without HMR involved) 👍 |
Contributor
Author
@onurtemizkan Awesome, thanks for testing. I will pass this by someone from the team and merge it in. I think we can close #6599 in the meanwhile - thanks for doing the foundational work!! |
lforst
changed the title
pageload transactions early
Contributor
size-limit report 📦
|
onurtemizkan
approved these changes
Jan 3, 2023
Collaborator
onurtemizkan
left a comment
onurtemizkan
left a comment
There was a problem hiding this comment.
Looks good to me! 🚀
Lms24
approved these changes
Jan 3, 2023
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Great work, looks like a good fix to me!
packages/react/src/reactrouterv6.tsx
Outdated
|
|
||
| let isBaseLocation: boolean = false; | ||
| let routes: RouteObject[]; | ||
| let previousLocation: Location | null = null; |
Member
There was a problem hiding this comment.
l: As discussed we can change this to a boolean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6470
This PR fixes a bug where we prematurely finish pageload transactions in our React Router 6 implementation due to some funky logic.
h/t to @onurtemizkan for doing the foundational work on this in #6599