test: Add Replay dependency resolution to Remix and NextJS integration tests #6570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Dec 16, 2022
Member
Author
My suspicion is that because the resolution didn't work, these tests simply downloaded the 7.26.0 replay package from NPM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken NextJS and Remix integration tests which were unable to look up the local version of
@sentry/replaybefore. Replay is now a dependency of these tests because they depend on@sentry/browser(which in turn depends on Replay after #6508).Not sure why we didn't catch this earlier, as afaict, our test job selection config already covers this change.
This should unblock our 7.27.0 release