Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Dec 15, 2022

This PR fixes a bug that breaks grouping in Sentry. Currently, when a stack frame doesn't have a line number we attach context lines based on line number 0. This is simply wrong and conflicts with grouping algorithms. We solve this by not attaching context lines at all for frames that do not have line numbers.

Some (ephemeral) context: https://sentry.slack.com/archives/GUCRT2B70/p1671103033977659

@lforst lforst marked this pull request as ready for review December 15, 2022 15:25
@lforst lforst requested a review from AbhiPrasad December 15, 2022 15:25
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.78 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.27 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.57 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.8 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.34 KB (0%)
@sentry/browser - Webpack (minified) 66.48 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.36 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.57 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.76 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.19 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.89 KB (+0.03% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.12 KB (+0.02% 🔺)

@AbhiPrasad AbhiPrasad requested a review from timfish December 15, 2022 15:39
@lforst lforst merged commit 3ef3918 into master Dec 15, 2022
@lforst lforst deleted the lforst-dont-attach-contextlines-when-no-lineno branch December 15, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants