Skip to content

Conversation

@theofidry
Copy link
Contributor

I believe extracting this into a dedicated function helps to:

  • Convey the intent: instead of having a statement and a comment explaining the statement, you directory have a descriptive and explanatory function name.
  • This also to further encapsulate additional information, here about a possible refactoring that would make it clearer.
  • Bonus: this was the only reason why let was being used, so now const can be used

@AbhiPrasad AbhiPrasad changed the title [Angular][ErrorHandler] Extract zonejs error unwrapper into a dedicated function ref(angular): Extract zonejs error unwrapper into a dedicated function Dec 6, 2022
@AbhiPrasad
Copy link
Member

Hey @theofidry thanks for opening PRs! I've taken the liberty to update your PR title based on our contributing docs. We'll review your contribution asap - please let us know if you have any questions.

@AbhiPrasad AbhiPrasad added the Package: angular Issues related to the Sentry Angular SDK label Dec 6, 2022
@theofidry
Copy link
Contributor Author

@AbhiPrasad thanks!

@AbhiPrasad AbhiPrasad merged commit 93eac4e into getsentry:master Dec 7, 2022
@theofidry theofidry deleted the feature/original-error branch December 7, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Package: angular Issues related to the Sentry Angular SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants