Skip to content

fix(node): Move profilesSampleRate into BaseNodeOptions #6409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2022
Merged

fix(node): Move profilesSampleRate into BaseNodeOptions #6409

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7ddbd9
fix(node): Move `profilesSampleRate` into Node Client Options
AbhiPrasad Dec 5, 2022
e9d56b0
remove file
AbhiPrasad Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/node/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ import { ClientOptions, Options, TracePropagationTargets } from '@sentry/types';
import { NodeTransportOptions } from './transports';

export interface BaseNodeOptions {
/**
* Sets profiling sample rate when @sentry/profiling-node is installed
*/
profilesSampleRate?: number;

/** Sets an optional server name (device name) */
serverName?: string;

Expand Down Expand Up @@ -56,9 +61,4 @@ export interface NodeOptions extends Options<NodeTransportOptions>, BaseNodeOpti
* Configuration options for the Sentry Node SDK Client class
* @see NodeClient for more information.
*/
export interface NodeClientOptions extends ClientOptions<NodeTransportOptions>, BaseNodeOptions {
/**
* Sets profiling sample rate when @sentry/profiling-node is installed
*/
profilesSampleRate?: number;
}
export interface NodeClientOptions extends ClientOptions<NodeTransportOptions>, BaseNodeOptions {}