ref(replay): Split replay integration & container class #6407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (session.id !== this.session?.id) { | ||
| session.previousSessionId = this.session?.id; |
Check failure
Code scanning / CodeQL
Insecure randomness
Contributor
size-limit report 📦
|
mydea
force-pushed
the
fn/replay-split
branch
from
7f83c10 to
e38b69b
Compare
Lms24
approved these changes
Dec 5, 2022
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
I like the change because a) single responsibility is always good and b) (as we previously discussed) it gets us one step closer to converting the replay logic into a functional structure. We can start thinking about this if we have the time after we finish our other points on the roadmap. Added a point to #5326.
| describe('integration settings', () => { | ||
| describe('blockAllMedia', () => { | ||
| it('sets the correct configuration when `blockAllMedia` is disabled', async () => { | ||
| const { replay } = await mockSdk({ replayOptions: { blockAllMedia: false } }); |
Member
There was a problem hiding this comment.
Good change (never knew that the previous syntax actually works 🤔 )
Member
Author
There was a problem hiding this comment.
yeah, we should prob. do that everywhere! But just stumbled over this because of some other refactoring made necessary here 😅
mydea
force-pushed
the
fn/replay-split
branch
from
e38b69b to
cf0604f
Compare
Member
Author
|
Note: I also added an entry to the MIGRATION docs. |
mydea
force-pushed
the
fn/replay-split
branch
from
cf0604f to
6a99d9d
Compare
billyvg
approved these changes
Dec 5, 2022
mydea
force-pushed
the
fn/replay-split
branch
3 times, most recently
from
09c1797 to
23c964d
Compare
mydea
force-pushed
the
fn/replay-split
branch
from
23c964d to
e643015
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #6406, this splits up the main
index.tsfile of replay into two parts: