Revert "fix(core): Only generate eventIds in client" #6392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6247
Fixes #6380
Reverting the PR that moved the event_id generation into the client because this is causing issues if you have async event processors. Although our processing pipeline uses
SyncPromise, async code can sneak in there, and this means that our event id's can be undefined.Since there is a workaround for the initial perf problem we are electing to just revert.