test(replay): Fix replay test tsconfig #6350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
The path is not correct (anymore)
mydea
force-pushed
the
fn/fix-replay-tsconfig
branch
from
cfe4f82 to
a2c77b6
Compare
Lms24
reviewed
Nov 30, 2022
| // it's purely a placeholder to satisfy VSCode. | ||
|
|
||
| { | ||
| "extends": "../tsconfig.test.json", |
There was a problem hiding this comment.
The path should be updated, right?
There was a problem hiding this comment.
yes! Actually, I also moved the whole file up to /test (instead of /test/unit), makes more sense IMHO!
8 tasks
Lms24
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) The comment is not allowed in a JSON file
b) The path is not correct (anymore)