Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 30, 2022

This PR cleans up the replay integration's package.json by getting rid of a few ToDos, enabling the circular dependency check and using the eslint cache of the monorepo.

Since the future of the demo app in the replay package is still unclear, I opted to repurpose and rename the bootstrap script so that it now only bootstraps the demo app. For the package itself, bootstrapping happens via a monorepo-level yarn command or lerna bootstrap command.

ref: #6280

@Lms24 Lms24 added the Package: replay Issues related to the Sentry Replay SDK label Nov 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.57 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.59 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.36 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.15 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.12 KB (0%)
@sentry/browser - Webpack (minified) 65.75 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.14 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.99 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.45 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.88 KB (+0.03% 🔺)
@sentry/replay index.js 37.2 KB (-40.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.17 KB (-40.05% 🔽)
@sentry/replay - Webpack (minified) 124.99 KB (-37.31% 🔽)

Base automatically changed from lms-replay-build-rollup to master November 30, 2022 16:24
@Lms24 Lms24 force-pushed the lms-replay-build-scripts branch from 0bed1e2 to 49b7bdb Compare November 30, 2022 16:33
@Lms24 Lms24 marked this pull request as ready for review November 30, 2022 16:33
@Lms24 Lms24 requested a review from mydea November 30, 2022 16:33
@Lms24 Lms24 merged commit 57bf5c3 into master Nov 30, 2022
@Lms24 Lms24 deleted the lms-replay-build-scripts branch November 30, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Package: replay Issues related to the Sentry Replay SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants