Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Nov 28, 2022

This PR does a few internal improvements to the replay tests.

Basically, there is a bit of a mix and match of how/when modules are mocked in the replay tests, making it hard to refactor some things. A bunch of things depend on import order etc. which is not great.

@mydea mydea added Type: Tests Package: replay Issues related to the Sentry Replay SDK labels Nov 28, 2022
@mydea mydea requested review from AbhiPrasad, Lms24 and lforst November 28, 2022 12:36
@mydea mydea self-assigned this Nov 28, 2022
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.54 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.42 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.21 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.94 KB (0%)
@sentry/browser - Webpack (minified) 65.25 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.96 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.96 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.41 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.83 KB (+0.01% 🔺)
@sentry/replay index.js 83.65 KB (-0.07% 🔽)
@sentry/replay - Webpack (gzipped + minified) 83.67 KB (-0.07% 🔽)
@sentry/replay - Webpack (minified) 272.53 KB (-0.06% 🔽)

@mydea mydea merged commit 0522caa into master Nov 28, 2022
@mydea mydea deleted the fn/replay-test-mocks branch November 28, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Package: replay Issues related to the Sentry Replay SDK Type: Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants