Skip to content

fix(build): Revert unintended Replay tsconfig changes #6300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2022
Merged

fix(build): Revert unintended Replay tsconfig changes #6300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84a5086
ref(build): revert unintended tsconfig changes
Lms24 Nov 25, 2022
5106c62
fix type errors in worker
Lms24 Nov 25, 2022
1828d0a
remove unnecessary size-check entry in pkg.json
Lms24 Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/replay/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ module.exports = {
{
files: ['worker/**/*.ts'],
parserOptions: {
project: ['config/tsconfig.worker.json'],
project: ['./config/tsconfig.worker.json'],
},
},
{
Expand Down
11 changes: 10 additions & 1 deletion packages/replay/config/tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
{
"compilerOptions": {},
"compilerOptions": {
"module": "esnext",
"moduleResolution": "node",
"noImplicitAny": true,
"noEmitOnError": false,
"esModuleInterop": true,
"resolveJsonModule": true,
"skipLibCheck": true,
"target": "es5"
},
"exclude": ["node_modules"]
}
6 changes: 0 additions & 6 deletions packages/replay/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,6 @@
"engines": {
"node": ">=12"
},
"size-limit": [
{
"path": "build/npm/index.js",
"limit": "4500ms"
}
],
"volta": {
"node": "14.21.1",
"yarn": "1.22.19"
Expand Down
12 changes: 2 additions & 10 deletions packages/replay/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,11 @@
{
"extends": "./config/tsconfig.core.json",
"compilerOptions": {
"module": "esnext",
"moduleResolution": "node",
"noImplicitAny": true,
"noEmitOnError": false,
"esModuleInterop": true,
"resolveJsonModule": true,
"skipLibCheck": true,
"types": ["node", "jest"],
"target": "es5",
"paths": {
"@test": ["./test"],
"@test/*": ["./test/*"]
}
},
"types": ["node", "jest"]
},
"include": ["src/**/*.ts", "test/**/*.ts", "rollup.config.ts", "jest.config.ts", "jest.setup.ts"],
"exclude": ["node_modules"]
Expand Down
2 changes: 2 additions & 0 deletions packages/replay/worker/src/handleMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ export function handleMessage(e: MessageEvent): void {
const id = e.data.id as number;
const [data] = e.data.args ? JSON.parse(e.data.args) : [];

// @ts-ignore this syntax is actually fine
if (method in handlers && typeof handlers[method] === 'function') {
try {
// @ts-ignore this syntax is actually fine
const response = handlers[method](data);
// @ts-ignore this syntax is actually fine
postMessage({
Expand Down