fix(replay): Ensure dropped errors are removed from replay reference #6299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
approved these changes
Nov 25, 2022
Lms24
approved these changes
Nov 25, 2022
mydea
force-pushed
the
fn/replay-remove-dropped-events
branch
3 times, most recently
from
30619a0 to
93feea9
Compare
billyvg
reviewed
Nov 29, 2022
| /** | ||
| * We overwrite `client.recordDroppedEvent`, but store the original method here so we can restore it. | ||
| */ | ||
| private _originalRecordDroppedEvent?: Client['recordDroppedEvent']; |
There was a problem hiding this comment.
I have been omitting the underscore prefix with private members since it's marked as private already but since this seems to be a pattern in js sdk, maybe we should update the replay sdk to follow this pattern.
There was a problem hiding this comment.
Yes, this is def. part of the todo list! :)
mydea
force-pushed
the
fn/replay-remove-dropped-events
branch
9 times, most recently
from
eb289af to
553b49c
Compare
mydea
force-pushed
the
fn/replay-remove-dropped-events
branch
from
553b49c to
e99110c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In replay, we attach errors that happened during replay-time via a global event handler.
However, due to various reasons some of these errors may be filtered out later. This leads to a weird user experience when there seem to be more errors that actually exist in sentry.
This PR fixes this (to a decent extend) by making sure we remove any error id that was actually dropped (due to rate limiting or because an integration/callback decided to drop it). For this, we monkey patch
recordDroppedEvent.Closes #6285