feat(core): Pass event as third argument to recordDroppedEvent
#6289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is optional. We need this for replay.
mydea
added
Package: core
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Nov 24, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For replay, we want to provide an easy (internal) way to strip out dropped events.
Our idea is to monkey patch
recordDroppedEventin replay, and use it to get notified of which events have been dropped, and handle that internally. This requires therecordDroppedEventcallback to actually receive the event as argument.This PR changes the signature so that it receives an error/transaction event as optional third argument. For other types of dropped events (e.g. attachments), undefined is passed.
ref #6285