chore(ember): Make tests less brittle #6164
Conversation
| 'ui.ember.runloop.actions | undefined', | ||
| 'ui.ember.runloop.routerTransitions | undefined', | ||
| 'ui.ember.runloop.render | undefined', | ||
| 'ui.ember.runloop.afterRender | undefined', | ||
| 'ui.ember.runloop.destroy | undefined', |
There was a problem hiding this comment.
l: Since you said that the order of these spans is the thing that makes the tests brittle, is there a way we can check that they are still present regardless of the order? Maybe some sort of "just make sure that some runloop spans are recorded" sort of thing? But you're obviously the Ember expert here, so if you say that there's no value in doing that, that's totally fine with me.
There was a problem hiding this comment.
We could do that, but that also goes into rather brittle territory - e.g. these are all auto-captured, and could even change between versions etc (theoretically).
I guess I can add a check that at least one runloop span has been added, that should be safe to do, and at least ensures that the overall runloop capturing happens!
mydea
force-pushed
the
fn/ember-flaky-test
branch
2 times, most recently
from
9a02920 to
5ffdbf7
Compare
We already had some logic to make test less brittle, but the runloop is a bit unstable, and thus hard to test. So it is easier to just don't test the runloop execution in detail, especially since these are the least interesting spans, and focus on testing the important parts (that are also more stable).
mydea
force-pushed
the
fn/ember-flaky-test
branch
from
5ffdbf7 to
b2250d3
Compare
We already had some logic to make test less brittle, but the runloop is a bit unstable, and thus hard to test. So it is easier to just don't test the runloop execution in detail, especially since these are the least interesting spans, and focus on testing the important parts (that are also more stable).