fix(otel): Remove sampling decision in propagator #6152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
force-pushed
the
abhi-otel-sampling
branch
from
ccb3ee4 to
b52f140
Compare
sl0thentr0py
reviewed
Nov 8, 2022
Member
sl0thentr0py
left a comment
sl0thentr0py
left a comment
There was a problem hiding this comment.
change is fine for me, but asked a question so we have some discussion on the edge case
| }; | ||
|
|
||
| // Only inherit sample rate if `traceId` is the same | ||
| if (traceparentData && traceId === traceparentData.traceId) { |
Member
There was a problem hiding this comment.
this state is obviously possible but it's not clear to me
- when that happens
- if there's a mismatch, we don't take the sampled decision, but what are the consequences of that in the later flow?
Member
Author
There was a problem hiding this comment.
I'm going to sleep on this and come back to it.
Member
Author
There was a problem hiding this comment.
Ok, so the only way there is a possible mismatch is if there is user mis-configuration - like they override span attributes themselves or do some custom logic. From what I read through, the SDK itself should not make this possible in any way.
With that in mind, I'm going to keep this guard anyway because I don't wanna re-run tests, but I don't think this check is necessary in other SDKs.
sl0thentr0py
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Sentry Propagator was setting the sample rate on the opentelemetry span context based on the incoming traceparent from
sentry-trace. This is problematic because it a span is unsampled, it does not enter a span processor. This means that we could create transactions erroneously (for example, unnecessarily promote a child span to a transaction).To fix this, we move the sampling decision from the propagator to the span processor.