Skip to content

test(nextjs): Attempt to make Next.js integration tests less flakey #6130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022
Merged

test(nextjs): Attempt to make Next.js integration tests less flakey #6130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/nextjs/test/integration/test/client/tracingClientGetInitialProps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ const {
const assert = require('assert').strict;

module.exports = async ({ page, url, requests }) => {
const requestPromise = page.waitForRequest(isTransactionRequest);
await page.goto(`${url}/42/withInitialProps`);
await page.waitForRequest(isTransactionRequest);
await requestPromise;

const transactionEnvelope = extractEnvelopeFromRequest(requests.transactions[0]);

Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/test/integration/test/client/tracingClientGetServerSideProps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ const {
const assert = require('assert').strict;

module.exports = async ({ page, url, requests }) => {
const requestPromise = page.waitForRequest(isTransactionRequest);
await page.goto(`${url}/1337/withServerSideProps`);
await page.waitForRequest(isTransactionRequest);
await requestPromise;

const transactionEnvelope = extractEnvelopeFromRequest(requests.transactions[0]);

Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/test/integration/test/client/tracingDynamicRoute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
const { expectRequestCount, isTransactionRequest, expectTransaction } = require('../utils/client');

module.exports = async ({ page, url, requests }) => {
const requestPromise = page.waitForRequest(isTransactionRequest);
await page.goto(`${url}/users/102`);
await page.waitForRequest(isTransactionRequest);
await requestPromise;

expectTransaction(requests.transactions[0], {
transaction: '/users/[id]',
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/test/integration/test/client/tracingFetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ const {
} = require('../utils/client');

module.exports = async ({ page, url, requests }) => {
const requestPromise = page.waitForRequest(isTransactionRequest);
await page.goto(`${url}/fetch`);
await page.click('button');
await page.waitForRequest(isTransactionRequest);
await requestPromise;

expectTransaction(requests.transactions[0], {
transaction: '/fetch',
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/test/integration/test/client/tracingNavigate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ const { sleep } = require('../utils/common');
const { expectRequestCount, isTransactionRequest, expectTransaction } = require('../utils/client');

module.exports = async ({ page, url, requests }) => {
const requestPromise = page.waitForRequest(isTransactionRequest);
await page.goto(`${url}/42/withInitialProps/`);
await page.waitForRequest(isTransactionRequest);
await requestPromise;

expectTransaction(requests.transactions[0], {
transaction: '/[id]/withInitialProps',
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/test/integration/test/client/tracingPageLoad.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
const { expectRequestCount, isTransactionRequest, expectTransaction } = require('../utils/client');

module.exports = async ({ page, url, requests }) => {
const requestPromise = page.waitForRequest(isTransactionRequest);
await page.goto(`${url}/healthy`);
await page.waitForRequest(isTransactionRequest);
await requestPromise;
Copy link
Member

@AbhiPrasad AbhiPrasad Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Might be nice to make this a util


expectTransaction(requests.transactions[0], {
contexts: {
Expand Down