feat(core): Add instrumenter option to ClientOptions
#6128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mydea
commented
Nov 3, 2022
AbhiPrasad
changed the title
instrumentor option to Node SDKinstrumenter option to Node SDK
mydea
force-pushed
the
fn/otel-instrumenter
branch
from
52a9a7f to
f05cdeb
Compare
mydea
changed the title
instrumenter option to Node SDKinstrumenter option to ClientOptions
AbhiPrasad
changed the title
instrumenter option to ClientOptionsinstrumenter option to ClientOptions
AbhiPrasad
approved these changes
Nov 3, 2022
mydea
added
Package: core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new option
instrumenterto the the client options, which can besentryoroteland defaults tootel.Nothing is done with that option yet, this will happen in follow up PRs.
It will only have an effect when being set in the node SDK.
ref #6127