fix(vue): Finish spans in component tracking before starting new ones for same operation

[lforst]

Attempts to fix #5693

We suspect that Vue does not always call cleanup hooks (e.g. updated, created, unmounted) in mixins. This would currently have the effect that we clobber old spans with new spans on hooks like beforeUpdated and never finish the spans.

This PR will simply finish unfinished spans for a particular lifecycle operation when they're not finished/cleaned up yet.

[AbhiPrasad]

We really need some vue tests 😭

In my eyes we should be storing the span using span ids when tracking, then we never have to worry about operations colliding with each other.

[lforst]

In my eyes we should be storing the span using span ids when tracking, then we never have to worry about operations colliding with each other.

Hm, but then we lose the opportunity to close old spans. There is a semantic difference and the question is what do we want operations that don't get cleaned up to look like?

Like this?

or like this?

My guess is that if they're not cleaned up, they likely got cancelled, in which case we should probably go for the first model (current) implementation.

[AbhiPrasad]

My guess is that if they're not cleaned up, they likely got cancelled, in which case we should probably go for the first model (current) implementation.

Yeah you know what, you're correct. Let's do this instead. I just read through the code and I was just misunderstanding some stuff.