fix: Use ts-node rather than bash for scripting integration bundling
#5789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Sep 22, 2022
Collaborator
Author
|
Builds are now run in parallel. On this machine previously |
Collaborator
Author
|
Oh no! I had the Now I've fixed this and added a
So it's still about 2x as quick on this machine. |
lobsterkatie
approved these changes
Sep 22, 2022
Member
lobsterkatie
left a comment
lobsterkatie
left a comment
There was a problem hiding this comment.
This has long been on my mental backlog - thanks for finally getting it done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using my Windows machine for the first time in ages and noticed this remaining bash script.
This PR converts the script to TypeScript and calls
ts-node