Skip to content

Conversation

@AbhiPrasad
Copy link
Member

We have a couple of key fixes to go out, notably #5675 and #5677, so I figured it's probably appropriate to cut a patch release here. There are some features, which may led to the argument that this should be a minor, but I can walk through them to justify the patch usage.

This is gated behind a flag, safe to ship in the patch

New feature, but just an add-on for existing route parameterization methods, nothing large so we can sneak it on

It's remix, so I'm comfortable with including new features here

utils is internal to us - we should be good to go!

@AbhiPrasad AbhiPrasad requested review from a team, lforst and lobsterkatie and removed request for a team September 1, 2022 18:26
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.42 KB (+0.03% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.08 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.99 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 52.94 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.79 KB (0%)
@sentry/browser - Webpack (minified) 64.33 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.81 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.66 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.91 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.28 KB (+0.02% 🔺)

@lforst lforst requested a review from Lms24 September 2, 2022 06:49
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cutting a patch rather than a minor is fine here (thx for the great explanations!)

@Lms24 Lms24 merged commit 9998ce3 into master Sep 2, 2022
@Lms24 Lms24 deleted the abhi-changelog-7.12.1 branch September 2, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants