fix(serverless): Check for existence of callback in GCP event handler before calling #5608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
commented
Aug 19, 2022
| fn: F, | ||
| wrapOptions: Partial<EventFunctionWrapperOptions> = {}, | ||
| ): EventFunctionWithCallback { | ||
| ): (...args: Parameters<F>) => ReturnType<F> | Promise<void> { |
Contributor
Author
There was a problem hiding this comment.
Unfortunately, we cannot just do F here since it produces some weird TS error I don't know how to fix.
Contributor
size-limit report 📦
|
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5607
This PR adds a check if a callback is provided to the GCP Events handler function before calling it. Additionally, it adjusts the types of the function so we would have caught this.