chore(nextjs): pin @types/react version to fix integration tests #5484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Jul 28, 2022
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Approve to unblock. We'll need to rebase all the PRs once this gets merged in. Let's chat about that strategy in daily.
| "@types/react": "^17.0.6", | ||
| // Hard-pinning @types/react because 17.0.48 causes build failures | ||
| "@types/react": "17.0.47", | ||
| "@types/react-dom": "^17.0.5", |
Member
There was a problem hiding this comment.
We'll need hard pin @types/react-dom as well, they need to be kept in sync
Member
Author
There was a problem hiding this comment.
Pinned it to 17.0.17 which seems to be the last version (was released way before @types/[email protected])
Member
There was a problem hiding this comment.
Wait, how are you having comments in package.json??
Member
Author
There was a problem hiding this comment.
We're not, realized this as soon as I pushed it (fixed in 88c171c)
Member
There was a problem hiding this comment.
Damn. I got all excited there for a minute...
This was referenced Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard-pins
@types/reactto version17.0.47(and@types/react-domto version17.0.17) because the latest patch (@types/[email protected]) caused our NextJs Integration tests to fail.Caused by: DefinitelyTyped/DefinitelyTyped#61457